-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.7.0-beta.6 broken package.json override #98
Comments
Thanks, yes these are betas for a reason! I will make sure to get a fix in this weekend. |
The System.config({
meta: {
'github:components/[email protected]/ember': {
deps: ['jquery', 'handlebars.js'],
exports: 'Ember'
}
}
}); I believe the issue is actually because Ember has updated to To manually override you can do:
If that works ok, we can create the new override file for the latest version like https://github.com/jspm/registry/blob/master/package-overrides/github/components/ember%401.4.0.json. The reason that we don't apply the registry overrides to the semver range is because it is expected to send a PR to the original repo and have this information in the underlying package.json for Ember itself. Perhaps we can reconsider this, but I'm tracking that decision here - jspm/registry#11. |
Super helpful and speedy answer as always :) Would it be possible to apply |
Potentially, but I don't want to start doing these fine-level optimizations when all of this stuff is still a little in flux. There is a spec change and package config coming to SystemJS which will both alter a few things around configuration. |
A spec - sounds nice. What I wanted kinda works, so I'm happy with that :) |
Before the upgrade I had ember running. Now the via
jspm install ember
installed ember package'spackage.json
is different.With the old jspm it automatically included
Now
dependencies
is an empty object andshim
doesn't exist.I think the algorithm that does these overrides broke. Maybe the ember package isn't the only broken package.
And another question:
I tried to fix this by applying the override manually. I did:
Out of curiosity: What am I doing wrong here? This should make the two globals exported by Handlebars and by jquery available to ember, right?
The text was updated successfully, but these errors were encountered: