Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify config.js vs .jspm/config #97

Closed
tauren opened this issue Aug 14, 2014 · 2 comments
Closed

Clarify config.js vs .jspm/config #97

tauren opened this issue Aug 14, 2014 · 2 comments

Comments

@tauren
Copy link

tauren commented Aug 14, 2014

The source file jspm-cli/lib/config.js appears to relate to two separate concerns. It deals with setting values into the global config file ~/.jspm/config and well as working with a project's config.js file. Unless these two concerns are intertwined, it might be better to break the file into two. This would help new developers to the project to better understand what each file is doing.

@guybedford
Copy link
Member

Definitely agreed that this file needs to be better structured (perhaps into lib/project.js for the package.json and lib/config.js for the global config and config helpers). The code also needs to be cleaned up as well.

@guybedford
Copy link
Member

Thanks - finally got around to this configuration refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants