Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode to the site #130

Closed
Himanshu-Agg12 opened this issue Feb 14, 2023 · 24 comments · Fixed by #365
Closed

Add dark mode to the site #130

Himanshu-Agg12 opened this issue Feb 14, 2023 · 24 comments · Fixed by #365
Assignees
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@Himanshu-Agg12
Copy link

Himanshu-Agg12 commented Feb 14, 2023

Add a button in the header for dark mode. The dark mode is more readable for the user.
Please assign this task to me i wanted to contribute to this great project.

@benjagm benjagm transferred this issue from json-schema-org/json-schema-org.github.io Oct 11, 2023
@benjagm benjagm added the ✨ Enhancement Indicates that the issue suggests an improvement or new feature. label Nov 23, 2023
@benjagm
Copy link
Collaborator

benjagm commented Nov 23, 2023

Hi @Himanshu-Agg12 . Are you still available to implement this enhancement?

@benjagm benjagm added the 💬 Question Further information is requested label Nov 23, 2023
@benjagm benjagm removed the 💬 Question Further information is requested label Dec 4, 2023
@benjagm benjagm added the Status: Available No one has claimed responsibility for resolving this issue. label Feb 20, 2024
@Gmin2
Copy link
Contributor

Gmin2 commented Feb 21, 2024

Can i get assigned as it is fairly a big issue !

@praveen-rikhari
Copy link
Contributor

Hey @benjagm any suggestions on how should we go ahead with this?? Do we have a theme for dark mode that we can leverage upon??

@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. labels Feb 22, 2024
@benjagm
Copy link
Collaborator

benjagm commented Feb 22, 2024

Do we have a theme for dark mode that we can leverage upon??

We don't have any theme to use. We need to build it from scratch.

@benjagm
Copy link
Collaborator

benjagm commented Feb 22, 2024

@Min2who @praveen-rikhari the issue is big, maybe you can consider working together on it. :-)

@praveen-rikhari
Copy link
Contributor

Sure @benjagm, @Min2who how would you like to proceed on this??

@Gmin2
Copy link
Contributor

Gmin2 commented Feb 22, 2024

Sure @benjagm, @Min2who how would you like to proceed on this??

I will make a draft PR soon You can commit in it ? Is this okay @praveen-rikhari

@Gmin2
Copy link
Contributor

Gmin2 commented Feb 26, 2024

@Min2who how would you like to proceed on this??

@praveen-rikhari you can proceed to complete the docs section

@benjagm
Copy link
Collaborator

benjagm commented Feb 26, 2024

If you are still working on the PR please update it to draft status until is ready to review. Great progress here!

1 similar comment
@benjagm
Copy link
Collaborator

benjagm commented Feb 26, 2024

If you are still working on the PR please update it to draft status until is ready to review. Great progress here!

@Gmin2 Gmin2 removed their assignment Feb 28, 2024
@praveen-rikhari
Copy link
Contributor

I am picking this up with some of the other ones as well

@benjagm
Copy link
Collaborator

benjagm commented Feb 28, 2024

@praveen-rikhari please continue the great work done by @utnim2. He did a lot of progress in the PR #365
Let's make sure you continue the work from there.

@praveen-rikhari
Copy link
Contributor

@benjagm currently working on these two issues

So, please can you unassign me and leave this for other contributor & @utnim2 Great work so far looks very good.
Thank you

@benjagm
Copy link
Collaborator

benjagm commented Feb 28, 2024

Ok @praveen-rikhari . @utnim2 Are you ok with finalising alone?

@praveen-rikhari
Copy link
Contributor

@benjagm Thanks

@DhairyaMajmudar
Copy link
Member

Ok @praveen-rikhari . @utnim2 Are you ok with finalising alone?

If it is okay I can help in this .

@praveen-rikhari
Copy link
Contributor

@DhairyaMajmudar Sounds great, please ask @benjagm @utnim2 regarding this.

@Gmin2
Copy link
Contributor

Gmin2 commented Feb 28, 2024

@DhairyaMajmudar you have 7 issues assigned it to yourself
image
It will be nice if a new contributor wants to do the work

@DhairyaMajmudar
Copy link
Member

Yes I have completed these issues and also linked a PR all of them : )

I think it will would be good issue for me.

@benjagm
Copy link
Collaborator

benjagm commented Feb 28, 2024

@jayprakash25 are you interested in continuing the great work done by @utnim2 for this issue in the PR #365?

@benjagm
Copy link
Collaborator

benjagm commented Feb 28, 2024

Yes I have completed these issues and also linked a PR all of them : )

I think it will would be good issue for me.

Everyone is doing a great job!

@jayprakash25
Copy link
Contributor

Yes @benjagm , I would like to contribute for this issue , may I know what else is to be done.

@benjagm
Copy link
Collaborator

benjagm commented Feb 28, 2024

All yours @jayprakash25 . Please sync with @utnim2 and continue with the draft PR he progressed.

@jayprakash25
Copy link
Contributor

Thanks @benjagm .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants