Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configurable cache key timeout #299

Open
vsemionov opened this issue Aug 13, 2023 · 0 comments
Open

Add a configurable cache key timeout #299

vsemionov opened this issue Aug 13, 2023 · 0 comments

Comments

@vsemionov
Copy link

Hi @jsocol ,

Thank you for your work on this amazing project. It has protected my application from attackers many times!

Currently, the code sets the request counters in cache keys without explicitly specifying a cache expiry timeout for these keys. And the timeout needs to be at least as large as the duration of the rate limit window. Adding a timeout setting would enable this package to handle long-term rate limits, while being backed by general-purpose caches, shared with other apps and having small default timeouts, leading to simpler deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant