Alternate solution for one-shot-subscribe (#666 and #667) #725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class-closures are a good way for creating closures with global scope in eus9.
However, when rethinking about #666 and #667, I have reached the conclusion that simply enforcing local closures should be enough for dealing with the
one-shot-subscribe
function.We can do that by:
unwind-protect
With this change:
This has minimal changes to the current implementation and is compatible with both eus9 and eus10.
@708yamaguchi @tkmtnt7000