[Fetch] Support head l515 (Part1) #1702
Conversation
sktometometo
changed the title
sktometometo
changed the title
sktometometo
changed the title
| @@ -15,4 +15,12 @@ for file in $(ls ./*.conf); do | |||
| echo "copied $file to /etc/supervisor/conf.d" | |||
| done | |||
|
|
|||
| # Enable jsk_dstat job to save the csv log under /var/log | |||
| ln -s /home/fetch/Documents/jsk_dstat.csv /var/log/ros/jsk-dstat.csv | |||
|
|
|||
There was a problem hiding this comment.
As I remember, @708yamaguchi had wanted to record cpu usage for navigation debugging. So he had added supervisor job to record performance with dstat
There was a problem hiding this comment.
where is jsk_dstat PR? please remove dstat related commit from this PR
There was a problem hiding this comment.
and create PR just for dstat for fetch robot
There was a problem hiding this comment.
I have created. #1825
There was a problem hiding this comment.
please remove dstat/supervisor commits from this PR
| @@ -1,6 +1,5 @@ | |||
| <launch> | |||
| <arg name="hostname" default="fetch15" /> | |||
| <arg name="launch_moveit" default="true" /> | |||
There was a problem hiding this comment.
why we move launch_moveit from fetch_bringup.launch to fetch.launch
There was a problem hiding this comment.
I don't know exactly why @knorth55 has moved it. But it may be because he want to run fetch arm with only fetch.launch.
There was a problem hiding this comment.
I think without this, we cannot tuck fetch arm when fetch_bringup.launch fails.
| @@ -0,0 +1,7 @@ | |||
| # This file is bash configuration for robot.conf | |||
| # This file must be at /var/lib/robot/config.bash | |||
There was a problem hiding this comment.
why this need to install under /var/lib instead of catkin worksapce ? https://github.com/tork-a/euslisp-release/blob/release/melodic/euslisp/env-hooks/99.euslisp.sh.in how we set environment variables.
There was a problem hiding this comment.
I have designed this as a configuration file for each robot. So it is intened to modify this file according to robot configuration. So I have to put it outside of git repository.
And this file will be used from multiple users since robot configuration will be the same from users. So I put it under /var/lib/robot/ as like other configuration files are (e.g. app_schedules.yaml, switchbot_token.txt, twitter_account_fetch_jsk.yaml and so on)
sktometometo
force-pushed
the
PR/fetchdev/support-head-l515
branch
from
c9c7047
to
e318b76
Compare
…nd install_supervisor.sh
…n fetch_gazebo_bringup.launch
sktometometo
force-pushed
the
PR/fetchdev/support-head-l515
branch
from
e318b76
to
b089d92
Compare
Support Head L515 for Fetch.
Some commits are excluded because of dependencies.