Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rosdep pcl_conversions to prevent pointcloud_screenpoint_nodelet error(groovy/rosbuild) #30

Merged
merged 1 commit into from
Apr 7, 2014

Conversation

aginika
Copy link
Contributor

@aginika aginika commented Apr 7, 2014

When I rosmake the jsk_pcl_ros in groovy/rosbuild, I got the below error.
[ 82%] Building CXX object CMakeFiles/jsk_pcl_ros.dir/src/pointcloud_screenpoint_nodelet.cpp.o
/home/*******/ros/groovy/jsk-ros-pkg/jsk_recognition/jsk_pcl_ros/src/pointcloud_screenpoint_nodelet.cpp:2:45: fatal error: pcl_conversions/pcl_conversions.h: No such file or directory
compilation terminated.

garaemon added a commit that referenced this pull request Apr 7, 2014
add rosdep pcl_conversions to prevent pointcloud_screenpoint_nodelet error(groovy/rosbuild)
@garaemon garaemon merged commit 95c2137 into jsk-ros-pkg:master Apr 7, 2014
@k-okada
Copy link
Member

k-okada commented Apr 8, 2014

Why did travis passed the test?
Jenkins also said it was OK.
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/jsk.rosbuild/55/

@k-okada
Copy link
Member

k-okada commented Apr 8, 2014

I suppose @aginika is forget to install pcl-conversions, please confirm that ros-groovy-pcl-conversions is installed and if not,
run https://github.com/jsk-ros-pkg/jsk_common/blob/master/rosdep-update.sh to install them. Just running rosdep udpate will not work since jsk-ros-pkg contains both manifest.xml and package.xml.

see jsk-ros-pkg/jsk_common#301 for discussion.

@aginika
Copy link
Contributor Author

aginika commented Apr 8, 2014

Yes... I forgot to run https://github.com/jsk-ros-pkg/jsk_common/blob/master/rosdep-update.sh .
Please revert it if you can.

@garaemon
Copy link
Member

garaemon commented Apr 8, 2014

I think it's not so bad to add pcl_conversions to manifest.xml.
However we should add depemd tag as well as rosdepmtag

@k-okada
Copy link
Member

k-okada commented Apr 8, 2014

Yes, I think correct manifest is

  <depend package="pcl" />
  <depend package="pcl_conversions" />
  <depend package="pcl_ros" />
  <depend package="opencv2" />
  <depend package="tf" />
  <depend package="sensor_msgs" />
  <depend package="geometry_msgs" />
  <depend package="stereo_msgs" />
  <depend package="nodelet" />
  <depend package="dynamic_reconfigure" />
  <depend package="std_srvs" />
  <depend package="std_msgs" />
  <depend package="image_transport" />
  <depend package="image_geometry" />
  <depend package="image_view2" />
  <depend package="eigen_conversions" />

  <rosdep name="tbb" />

@k-okada
Copy link
Member

k-okada commented Apr 9, 2014

@aginika could you create one more PR on manifest.xml, which I suggested in #30 (comment)?

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants