[colcon][jsk_data] Support download_data with colcon #1803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves 2 problems.
rospkg.RosPack.pkg_name
doesn't return the current building package's src directory whencolcon build
. So while building the package likejsk_perception
,download_data
tries to download in/opt/ros/share/jsk_perception
and fails because of permission error. This PR fixes it.colcon build
,$ROS_PACKAGE_PATH
always returns the workspace's install path, not thesrc
directory. This PR downloads data in theinstall/<some path>/share
directory forrospkg
to find the appropriate path.cc: @sugikazu75