Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[colcon][jsk_data] Support download_data with colcon #1803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mqcmd196
Copy link
Member

This PR solves 2 problems.

  • rospkg.RosPack.pkg_name doesn't return the current building package's src directory when colcon build . So while building the package like jsk_perception , download_data tries to download in /opt/ros/share/jsk_perception and fails because of permission error. This PR fixes it.
  • When using colcon build, $ROS_PACKAGE_PATH always returns the workspace's install path, not the src directory. This PR downloads data in the install/<some path>/share directory for rospkg to find the appropriate path.

cc: @sugikazu75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant