Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Set ROS_MASTER_URI to localhost in *robot*_play.sh #1612

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

708yamaguchi
Copy link
Member

By this pull request, ROS_MASTER_URI is set to localhost in *robot*_play.sh. (e.g. pr2_play.sh)
This program will prevent launching rosbag play node in master robot.

Merge after #1611

@k-okada
Copy link
Member

k-okada commented Feb 22, 2019

Did you consider writing something like

<launch>                                                                                                               
  <arg name="ROS_MASTER_URI" default="$(env ROS_MASTER_URI)" />
  <env name="ROS_MASTER_URI" value="$(arg ROS_MASTER_URI)" />
</launch>

I am not so confident, so there might be a drowback.

@k-okada
Copy link
Member

k-okada commented Apr 25, 2019

waiting for feedback @708yamaguchi @iory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants