Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engines does not match ci #72

Closed
wraithgar opened this issue Oct 21, 2024 · 3 comments
Closed

engines does not match ci #72

wraithgar opened this issue Oct 21, 2024 · 3 comments

Comments

@wraithgar
Copy link

When node <18 was dropped from CI, the engines field was not also updated. It still reads >=0.6.

I assume this is now incorrect.

$ npm view negotiator version engines
version = '1.0.0'
engines = { node: '>= 0.6' }
@bjohansebas
Copy link
Member

Hi @wraithgar, you are correct, the engine has not been updated. We have an open discussion on the topic that you can see at expressjs/discussions#286.

@wraithgar
Copy link
Author

Closing as a duplicate then, thanks!

@wraithgar wraithgar closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2024
@blakeembrey
Copy link
Member

blakeembrey commented Oct 22, 2024

@wraithgar This is a good catch and appears to be a bug/mistake when releasing 1.0.0, I'll bump that now.

Updated: a63518a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants