-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minify db.json
file
#290
Comments
Yes, I agree. I have a branch (but looking it seems to not be pushed yet) that actually does that and more, with that exact goal: make the package size as small as possible. It requires changes to even the release process, of course, since it will no longer match what it on the github, but it is in progress 👍 |
Looking at my branch, it looks like I have an intermediate change I can actually push up that reduces the size by 70kb even. |
I will need to take a closer look at my changes tomorrow or so 👍 hopefully I can land them here soon. |
Cool! I'm curious to see how you managed to get the size down by that much. |
Hey @dougwilson any updates on this? |
By minifying the
db.json
file (stripping whitespace, newlines, etc) before uploading we could reduce the size of this package by about 40KB (uncompressed).Size based on
master
:Size with minified
db.json
file:We could accomplish this by directly minifying the JSON output from
npm run build
, or by having a script to minify the file right before uploading to NPM.I don't see any deploy scripts or anything, but I would be happy to write a pre-upload script of sorts to accomplish this if we decide it is worth it.
Thanks!
The text was updated successfully, but these errors were encountered: