params overloading

[rlidwka]

Is there any point in doing create(404, 'message') when you can use create[404]('message') ?

Also, you can do create(404, 'message') as well as create('message', 404), which will be pain to support if we decide to change that.

I'm now thinking about literally shadowing global Error object with this one:

var Error = require('http-error')
throw new Error('this would work as usual')
throw new Error[404]('this would work as http error')

... and things like treating numbers as status codes might break the idea.

[Fishrock123]

I think we should have just one syntax. That last bit is an interesting idea, but how might it play with other things?

[jonathanong]

i'd much rather support create(404, 'message') vs. using []s anywhere. it was mainly for backawrds compat for me because i hijacked someone else's module

[rlidwka]

i'd much rather support create(404, 'message')

Ohh... okay. But what about not supporting create('message', 404)?

You can even do funny stuff like create(403, 404, 500) right now, which is equivalent to create(500).

[jonathanong]

lol why you do that. it's mostly because we support errors and stuff too and i ended up with like 4 if statements then gave up

[rlidwka]

That last bit is an interesting idea, but how might it play with other things?

Well... I'm gonna try that: rlidwka/sinopia@a5cd498

If it fails horribly, I'll let you know. :P

[chazmo03]

What if you also overload the factories to accept Error objects instead of just messages? This way you add the status and pass along the error.

something.do(function(err) {
    if (err) { return next(create[400](err)); }
    ...
}

[dougwilson]

@chazmo03 we would only do that if you could do the same for TypeError, etc. Those are not factories, but classes.

[chazmo03]

@dougwilson Looking into the code, index.js:19, it looks like this is already possible, just not documented. Running the following seems to create errors with appropriate codes but with different messages. Am I missing something?

createError[400]('Err!').message
createError[400](new Error('Err!')).message
createError[400](new TypeError('Err!')).message

[dougwilson]

Um, line 19 is the factory. You are not calling that factory, because you are doing createError[400], which is a class. You want to be doing createError(400, new Error('Err!')) to use the factory.

[dougwilson]

I added a deprecation to the one thing everyone agreed upon here: taking the status code as the non-first argument in the factory function. We'll see if there is heavy push back when it gets published.