Deprecate using non-error status codes

jshttp · Feb 14, 2017 · 858d082 · 858d082
1 parent 4b45191
commit 858d082
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -4,6 +4,7 @@ unreleased
   * Accept custom 4xx and 5xx status codes in factory
   * Add deprecation message to `"I'mateapot"` export
   * Deprecate passing status code as anything except first argument in factory
+  * Deprecate using non-error status codes
   * Make `message` property enumerable for `HttpError`s
 
 2016-11-16 / 1.5.1

diff --git a/index.js b/index.js
@@ -73,6 +73,10 @@ function createError () {
     }
   }
 
+  if (typeof status === 'number' && (status < 400 || status >= 600)) {
+    deprecate('non-error status code; use only 4xx or 5xx status codes')
+  }
+
   if (typeof status !== 'number' ||
     (!statuses[status] && (status < 400 || status >= 600))) {
     status = 500