You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
either Fields() needs to take a string that can help decide which interfaces get returned, or a new method FieldsForStream(string)? needs to be added to the interface that allows the bolt to return fields dependent on the streamId passed.
The text was updated successfully, but these errors were encountered:
Yes, this is a gap we saw when we added the ShellBolt and ShellSpout wrappers for the conn objects. I would prefer to just take the pain now and break the interface. Maybe this is a good time to start versioning GoStorm. In the release notes for the new version we can specify the breaking change and we can add a section to the readme to tell the user to use the gofmt tool to help fix the breaking changes with something like: gofmt -r 'func Fields() -> func Fields("default")' -w *.go. Of course I'm still not entirely happy with how Fields works.
We'll also have to rethink how the ShellBolt handles its connection. Currently it requests fields from the fields factory and then reads the metadata and fields from the connection. We now need to first read the metadata, maybe buffer the fields bytes, Use the metadata to obtain the correct fields objects and then use the conn again to correctly unmarshall the fields. We need to think on whether we can't find a more elegant solution here.
either Fields() needs to take a string that can help decide which interfaces get returned, or a new method FieldsForStream(string)? needs to be added to the interface that allows the bolt to return fields dependent on the streamId passed.
The text was updated successfully, but these errors were encountered: