Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request module (jsforce dependency) is deprecated #999

Closed
techieshark opened this issue Mar 20, 2020 · 7 comments
Closed

request module (jsforce dependency) is deprecated #999

techieshark opened this issue Mar 20, 2020 · 7 comments
Labels
fixed in v2 fixed in the `2.0` branch

Comments

@techieshark
Copy link

The request package has been deprecated: request/request#3142. Additionally, its latest published version, 2.88.2, adds a deprecation warning whenever it is npm-installed. I don't think this is an issue immediately for jsforce but presumably will be should that package be updated in the lockfile.

Alternatives have been listed at: request/request#3143

@lcampos
Copy link

lcampos commented Feb 4, 2021

Does anyone know if an existing maintainer (or someone else) is looking into this ?

@dorr-home
Copy link

This issue has been open for a long time and now is subject to security vulnerability (see https://nvd.nist.gov/vuln/detail/CVE-2023-28155).

@cristiand391 cristiand391 added the fixed in v2 fixed in the `2.0` branch label Oct 2, 2023
@cristiand391
Copy link
Member

cristiand391 commented Oct 2, 2023

quick update:
request has been replaced by node-fetch in the 2.0 branch for a long time. We will consider removing node-fetch from jsforce once node's fetch stabilizes (node v20 maybe?: nodejs/node#45684).

aside from security fixes, we aren't doing any feature work on jsforce v1. Will close this once jsforce v3 is GA.

@MaPDores
Copy link

MaPDores commented Oct 6, 2023

Hi @cristiand391,

Since this is a security vulnerability, do you have any expected date for the fix to be released?

@cristiand391
Copy link
Member

@MaPDores we are currently working on finishing jsforce v3 and don't plan to fix this in v1, see:
#1360

The reason is that v2 was already refactored to use node-fetch and we don't have the bandwidth to backport it to v1 in a safe way (test jobs in master are old/broken, Salesforce CLI e2e runs on jsforce v2 branches but don't work on v1).

We don't have a hard deadline for the GA, but I would say about ~1 month.

@omril1
Copy link

omril1 commented Jun 17, 2024

This has been like that for a long time, Is there a workaround for this?

@cristiand391
Copy link
Member

This should be fixed in v3, see: #1529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in v2 fixed in the `2.0` branch
Projects
None yet
Development

No branches or pull requests

6 participants