Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multieffector regression #15

Open
jsantell opened this issue Aug 24, 2019 · 2 comments
Open

Multieffector regression #15

jsantell opened this issue Aug 24, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@jsantell
Copy link
Owner

Traced back to the three.js change from r91 to r102, there was something introduced in that change that results in there being empty space when a multieffector is pulled far enough:

r91:
Screenshot from 2019-08-24 15-51-00

r102 (and r107):
Screenshot from 2019-08-24 15-51-28
@jsantell jsantell added the bug Something isn't working label Aug 24, 2019
@jsantell
Copy link
Owner Author

Checking out the migration guide for patches, I'm guessing it's due to the Object.lookAt() change from r96

@arpu
Copy link

arpu commented Sep 28, 2019

this is the diff for this
mrdoob/three.js@7504c8a#diff-67b76c11cf60452cd34cbaeadab83d05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arpu @jsantell