Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CentOS base has outdated CMAKE #157

Closed
ILOVEPIE opened this issue Mar 16, 2019 · 2 comments · Fixed by #210
Closed

CentOS base has outdated CMAKE #157

ILOVEPIE opened this issue Mar 16, 2019 · 2 comments · Fixed by #210

Comments

@ILOVEPIE
Copy link
Contributor

May need to update the CentOS base's version, currently this is blocking #155 and preventing a pass on the checks.

@jrottenberg
Copy link
Owner

I see :

  CMake 3.5 or higher is required.  You are running version 2.8.12.2

The centos variant from is 7 so not much we can do there at the from level, maybe :

yum -y install epel-release
yum install cmake3

@hvindin
Copy link
Contributor

hvindin commented Jan 15, 2020

I've just opened 2 PR's which should both fix the version of cmake required to build x265.

Using a centos:8 base container feels like an ok thing to do given that it's just the latest release of centos, but may cause issues for anyone who has forked off and gone and done their own thing assuming centos:7

Just using cmake3 rather than cmake seems to work, but I'm not sure if it might cause some weird error in the built files because a lib detected centos v7 and configured itself assuming cmake v2 (I've seen it happen, and it's a terrible thing to put in your build scripts, but I guess if it works...)

They should both technically fix the cmake issue...

The other alternative would be to make cmake (as in the command) a variable, then for all of the other templates set it to cmake and for the centos container set it to cmake3, or possibly at an even more specific level for this issue set it to cmake for all of the builds except the ones which need cmake3 and just have two cmake variables, both set to cmake for every other distro, but set differently in centos. Feels like it would get very complicated very fast though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants