-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CentOS base has outdated CMAKE #157
Comments
I see :
The centos variant from is
|
I've just opened 2 PR's which should both fix the version of cmake required to build x265. Using a centos:8 base container feels like an ok thing to do given that it's just the latest release of centos, but may cause issues for anyone who has forked off and gone and done their own thing assuming centos:7 Just using cmake3 rather than cmake seems to work, but I'm not sure if it might cause some weird error in the built files because a lib detected centos v7 and configured itself assuming cmake v2 (I've seen it happen, and it's a terrible thing to put in your build scripts, but I guess if it works...) They should both technically fix the cmake issue... The other alternative would be to make |
May need to update the CentOS base's version, currently this is blocking #155 and preventing a pass on the checks.
The text was updated successfully, but these errors were encountered: