Allow for inputs in other units of temperature and pressure in tg51.p_tp() #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd verify backwards compatibility
|
I hope you will accept this as I couldn't let #110 rest :-D |
jrkerns
added a commit
that referenced
this pull request
Sep 9, 2022
add mean WL measurement * add mean measurement * document changes Approved-by: Randy Taylor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements pint.Quantity inputs in tg51.p_tp() function to also allow inputs in other units, like for instance mbar or kPa. Backwards compatibility is maintained by type checking inputs.
I also extended the unittest to makek sure implemented changes work for the already present cases as well as the new option of pint.Quantity based inputs.