Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SourceNeedle is referenced in generated position methods, but is not exported #31

Closed
connor4312 opened this issue Jan 5, 2024 · 2 comments · Fixed by #32 or #34
Closed

The SourceNeedle is referenced in generated position methods, but is not exported #31

connor4312 opened this issue Jan 5, 2024 · 2 comments · Fixed by #32 or #34

Comments

@connor4312
Copy link
Contributor

connor4312 commented Jan 5, 2024

all/generatedPositionFor references the SourceNeedle, but this is not exported from the package root, which makes consumption a bit ugly, requiring importing from the types file directly if one wants to pass it through places.

@jridgewell jridgewell transferred this issue from jridgewell/gen-mapping Jan 5, 2024
@jridgewell
Copy link
Owner

I think at this point we can use export type * from './types' so that I stop missing some of the types.

@connor4312
Copy link
Contributor Author

connor4312 commented Jan 5, 2024

That would make sense 👍

Btw, I finally moved the vscode JS debugger over from the old source-map library to this one. I'm quite happy to have gotten that ripped out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants