-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] fix "exports" for node 13.0-13.6 #4
Conversation
`engines.node` explicitly says ">= 6", which includes node 13.0-13.6, which is broken without this change. This came up because `@babel/generator` now depends on this package.
How is it broken? The docs say this is supported: https://nodejs.org/docs/latest-v13.x/api/esm.html#:~:text=main.js%22%0A%7D-,Conditional%20Exports,-%23 |
Conditional exports, first introduced in 13.2, were behind the flag |
Yep - node 13.0-13.1 only supports the string form (which is a bug that those versions of node consider "exports" at all), and 13.2-13.6 only support "default" (13.7 added "require"). The string fallback should cover both (adding "default" to the object would cover 13.3-13.6 alone) |
Ok. What's the urgency of this to release? |
I mean, I’d say low given that few people are using node 13.0-13.6, but I’d hope it would be a quick patch regardless? |
Thanks! Released in v0.3.2. |
…9 due to jridgewell/gen-mapping#4" This reverts commit 4cdb72f.
[meta] fix "exports" for node 13.0-13.6
engines.node
explicitly says ">= 6", which includes node 13.0-13.6, which is broken without this change.This came up because
@babel/generator
now depends on this package.