Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose date localizer #1347

Merged
merged 1 commit into from
Jun 9, 2019
Merged

Expose date localizer #1347

merged 1 commit into from
Jun 9, 2019

Conversation

TrySound
Copy link
Collaborator

@TrySound TrySound commented Jun 9, 2019

I use date-fns and have custom localizer. Though I need to import
internals to create it. Would be good to have it in public api.

Also did you consider to use named exports instead of Object.assign?

I use date-fns and have custom localizer. Though I need to import
internals to create it. Would be good to have it in public api.

Also did you consider to use named exports instead of Object.assign?
Copy link
Owner

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember really but I don't think there is any strong reason named exports aren't used here

@jquense jquense merged commit 5d93c9d into jquense:master Jun 9, 2019
@TrySound TrySound deleted the expose-date-localizer branch June 9, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants