-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle None being passed explicitly to startJVM #1134
Handle None being passed explicitly to startJVM #1134
Conversation
90c77b9
to
d847350
Compare
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 112 112
Lines 10276 10276
Branches 4032 4032
=======================================
Hits 9027 9027
Misses 698 698
Partials 551 551
|
Thanks, I've overlooked this one too. Do you think there are more spots like this? :) |
Already the |
|
||
def testPathTwice(self): | ||
with self.assertRaises(TypeError): | ||
jpype.startJVM(self.jvmpath, jvmpath=self.jvmpath) | ||
|
||
def testBadKeyword(self): | ||
with self.assertRaises(TypeError): | ||
jpype.startJVM(invalid=True) | ||
jpype.startJVM(invalid=True) # type: ignore |
Check failure
Code scanning / CodeQL
Wrong name for an argument in a call
Following-up with my comment in https://github.com/jpype-project/jpype/pull/1062/files#r1182683565.
Apologies to @marscher for missing this in #1062.