Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FileSystemResolver #96

Open
2 tasks
jpstroop opened this issue Sep 17, 2016 · 2 comments
Open
2 tasks

Refactor FileSystemResolver #96

jpstroop opened this issue Sep 17, 2016 · 2 comments

Comments

@jpstroop
Copy link
Owner

jpstroop commented Sep 17, 2016

  • Make the cache a class (implement __get__, get, and __set__ to hide file copying and deleting, and internally manage a SafeLruDict)
  • Make a ResolvedFile class (or something like that), that can hold a file's path, cache path, last mod, tell if it's stale, etc. See note in loris/resolvers/file_system_resolver.py
@jpstroop
Copy link
Owner Author

Alternatively, if we didn't want to go this far (it's not as clean as the above makes it sound) then move the cache behaviors into a superclass or Mixin so that other cache implementations can use it.

@jpstroop
Copy link
Owner Author

Also #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant