You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When calling move() it checks if the destination exists, and if it does it refuses to call rename. This means you can't change the case on a case-insensitive file system.
Fs-extra should check that the destination has the same inode before refusing to move.
The test itself is really simple: try to rename a file from lowercase to uppercase, it will fail when executed on a case-insensitive fs. The question is, can your test suite simulate that?
@wmertens I finally found some time to dig into your case! So here is what I found:
I appreciate if you would respect our issue template and respond to 3 simple questions that would help us resolve YOUR issue faster!
If you are using the latest version of fs-extra, we actually check the inodes of src and dest (as well as other properties) to determine if src and dest are the same before moving! However I just realized that implementation doesn't support cases like yours (when you want to just change the case) and I am working on that!
We actually have a test file for cases like this, however again I just realized that those tests are broken for case-insensitive systems! Currently for case-insensitive systems those tests expect an error thrown however the corect behavior should allow users change the case for case-insensitive systems! and I am working on that too!
When calling move() it checks if the destination exists, and if it does it refuses to call
rename
. This means you can't change the case on a case-insensitive file system.Fs-extra should check that the destination has the same inode before refusing to move.
node-fs-extra/lib/move/move.js
Line 41 in 40c3d68
The text was updated successfully, but these errors were encountered: