Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remove() & move() wildcards (introduced by rimraf) #177

Closed
jprichardson opened this issue Sep 14, 2015 · 8 comments
Closed

fix remove() & move() wildcards (introduced by rimraf) #177

jprichardson opened this issue Sep 14, 2015 · 8 comments

Comments

@jprichardson
Copy link
Owner

No description provided.

@jprichardson
Copy link
Owner Author

Also on move.

@jprichardson
Copy link
Owner Author

isaacs/rimraf@04f1a13

@danielkcz
Copy link

@jprichardson Just little side node here, please mention in docs that those methods are actually a wrapper around rimraf. I was just looking if I can use globbing pattern there and had to dive into code to find out about this. Thanks for the module either way, I like to have things tucked together like this.

@RyanZim RyanZim changed the title fix remove() wildcards (introduced by rimraf) fix remove() & move() wildcards (introduced by rimraf) Oct 26, 2016
@siyb
Copy link

siyb commented Nov 7, 2016

Somehow, this does not seem to work any more (using Version 1.0.0):

fs.remove(storagePath, err => {
if(err)...;
console.log('REMOVED', storagePath)
});

output:

REMOVED /tmp/myproject/test/unit/*

$ ls -l /tmp/myproject/test/unit/|wc -l
10

@RyanZim
Copy link
Collaborator

RyanZim commented Nov 7, 2016

This issue should be closed, it is fixed.

@siyb fs-extra does not support globbing. It did support it for remove and move, but this was inconsistent with the rest of the API, so we removed it in v1.0.0. https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md#100--2016-11-01

@RyanZim RyanZim closed this as completed Nov 7, 2016
@jprichardson
Copy link
Owner Author

jprichardson commented Nov 7, 2016

@siyb what happened is that fs-extra never supported globbing nor was it ever documented. rimraf came along and introduced globbing which fs-extra depended upon. fs-extra will support globbing at some point, but we need it to be consistent across the entire API.

If this is something you'd be willing to help us with, we'd love to have your help.

@jacobq
Copy link
Contributor

jacobq commented Sep 17, 2019

fs-extra will support globbing at some point, ...

Is it available? Where can one track the status of this? Perhaps here?

@RyanZim
Copy link
Collaborator

RyanZim commented Sep 18, 2019

Yes.

Repository owner locked as resolved and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants