Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fse.move directories across multiple devices doesn't work #108

Closed
nicks opened this issue Jan 27, 2015 · 5 comments
Closed

fse.move directories across multiple devices doesn't work #108

nicks opened this issue Jan 27, 2015 · 5 comments

Comments

@nicks
Copy link
Contributor

nicks commented Jan 27, 2015

Create a dir on another device:

mkdir -p /path/to/my/dir

Then try to move it:

var fs = require('fs-extra')
fs.move('/path/to/my/dir', './nick', function (err) {
  if (err) throw err
})

fs.move reports success, and deletes the old directory, but does not actually create the new directory. It just creates an empty 0-length file.

Tested on Linux ip-10-37-137-70 3.10.42-52.145.amzn1.x86_64 #1 SMP Tue Jun 10 23:46:43 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

@jprichardson
Copy link
Owner

Awesome, thanks! Looking into it..

@jprichardson
Copy link
Owner

Got VM setup, mounted an external device, verified problem. Working on a fix...

@jprichardson
Copy link
Owner

Fixed. Relevant test here: https://github.com/jprichardson/node-fs-extra/blob/master/test/move.test.js#L171 I'm looking over some fs.copy stuff before I publish the new version. New version should be published soon.

@jprichardson
Copy link
Owner

@nicks
Copy link
Contributor Author

nicks commented Jan 28, 2015

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants