commit fails on RiverSource.closeReading when database connection is already closed

[metysj]

It seems harmless, but with SQLite, calling closeReading fails and throws and exception in the logs as the database connection is already closed.

             // always commit before close to finish cursors/transactions
             if (!readConnection.getAutoCommit()) {
                 readConnection.commit();
             }
             if (!readConnection.isClosed()) {
                 readConnection.close();
             }

It seems like the test should be:

             // always commit before close to finish cursors/transactions
             if (!readConnection.isClosed() && !readConnection.getAutoCommit()) {
                 readConnection.commit();
             }
             if (!readConnection.isClosed()) {
                 readConnection.close();
             }

[jprante]

Thanks, fixed in 1.2.0.1