Double close causes exception, which violates Closeable contract. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2013 13:47
/**
* Closes this stream and releases any system resources associated
* with it. If the stream is already closed then invoking this
* method has no effect.
*
* @throws IOException if an I/O error occurs
*/
public void close() throws IOException;
Show that double-close is broken in a way that violates the contract.
|
OK, in practice I think this is not a big deal (a stream which is finished but not closed seems useless to me) but I have updated the PR. Does it look good now? |
jpountz
added a commit
that referenced
this pull request
Jul 12, 2013
Double close causes exception, which violates Closeable contract.
|
The use-case for not closing a finished stream is to be able to keep writing data on the underlying stream. However I agree that most users won't use this feature and just close the stream when they are done adding data to it. The PR looked good, I just merged it. Thanks! |
|
Hi @jpountz, can you make a release with this fix? Thanks! |
|
There are a couple of issues that I would like to fix before the next release, I'll do it ASAP. |
|
@stevenschlansker 1.2.0 should be available from the maven repo now, it contains your fix. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LZ4's block streams inherit Closeable. Closeable's contract specifies:
Show that double-close is broken in a way that violates the contract. Add a fix.