Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangs after connection is lost #10

Closed
thvdveld opened this issue Jan 4, 2021 · 6 comments
Closed

Hangs after connection is lost #10

thvdveld opened this issue Jan 4, 2021 · 6 comments

Comments

@thvdveld
Copy link

thvdveld commented Jan 4, 2021

After connection is lost and reset, the player hangs (running with WiFi).
This is the output:

[2021-01-04T15:21:39Z ERROR psst_gui::delegate] connection error: IoError(Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" })
[2021-01-04T15:21:42Z INFO psst_gui::delegate] session connected
[2021-01-04T15:22:07Z INFO psst_core::stream_storage] blocked at 8992924
[2021-01-04T15:22:07Z INFO psst_core::stream_storage] blocked at 7408684
[2021-01-04T15:22:07Z INFO psst_core::stream_storage] blocked at 7447668
[2021-01-04T15:22:07Z INFO psst_core::stream_storage] blocked at 6179592
[2021-01-04T15:22:07Z INFO psst_core::audio_player] stale open result received, ignoring

After this, nothing happens, unless selecting a new song.

@thvdveld
Copy link
Author

thvdveld commented Jan 4, 2021

This now seems to happen after every song. I recall having the same issue when I was using spotify-tui and I think the problem was the client couldn't handle a connection reset (Rigellute/spotify-tui#178 and librespot-org/librespot#134).

@jpochyla
Copy link
Owner

jpochyla commented Jan 4, 2021

I think this is a bug unrelated to Spotify connection, caused by d136d3b. I'm on it!

@jpochyla
Copy link
Owner

jpochyla commented Jan 4, 2021

Should be fixed in da88499. Leaving this issue open as network resiliency is on the roadmap.

@thvdveld
Copy link
Author

thvdveld commented Jan 4, 2021

It has been working now with no issues for 2 hours! 🎉 Nice work and thanks for the fast fixes!

@kirillrogovoy
Copy link

I have this problem on macOS 12.3.1 and the latest Psst.

Only that in my case, it hangs until I restart the app. I can still browse the catalog, but the playback is dead.

@conartist6
Copy link

All issues related to this problem are "closed as completed" which seems misleading, and makes it more difficult to find librespot-org/librespot#609. Once a user does find it they need to read the entire thread to figure out if the problem still exists. It definitely seems to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants