Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme-next.css imports invalid CSS variables #4302

Closed
4 of 11 tasks
liamsms opened this issue Oct 15, 2024 · 1 comment · Fixed by #4306
Closed
4 of 11 tasks

theme-next.css imports invalid CSS variables #4302

liamsms opened this issue Oct 15, 2024 · 1 comment · Fixed by #4306
Labels
community For issues that have been raised by folks outside the core Salt team priority: high 😡 type: bug 🪲 Something isn't working

Comments

@liamsms
Copy link
Contributor

liamsms commented Oct 15, 2024

Latest version

  • I have tested the latest version

Description

Some of the custom CSS variables imported by theme-next.css are missing a hyphen which causes Turbopack parser to fail

 ⨯ ModuleBuildError: ./node_modules/@salt-ds/theme/css/theme-next.css:829:86
Parsing css source code failed
> 829 |   --salt-actionable-negative-foreground-disabled: var(--salt-palette-negative-strong disabled);

Steps to reproduce

  1. Import theme-next.css
  2. Start app using latest Next.js + Turbopack next dev --turbo

Expected behavior

No response

Package name(s)

Theme (@salt-ds/theme)

Package version(s)

1.23.0

Browser

  • Chrome
  • Safari
  • Firefox
  • Microsoft Edge

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@liamsms liamsms added status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working labels Oct 15, 2024
@origami-z origami-z added community For issues that have been raised by folks outside the core Salt team priority: high 😡 and removed status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels Oct 15, 2024
@origami-z origami-z mentioned this issue Oct 15, 2024
Merged
@origami-z
Copy link
Contributor

@liamsms thanks for raising. will hotfix asap

@origami-z origami-z mentioned this issue Oct 15, 2024
Open
@github-actions github-actions bot mentioned this issue Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community For issues that have been raised by folks outside the core Salt team priority: high 😡 type: bug 🪲 Something isn't working
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version Packages jpmorganchase/salt-ds
2 participants
@origami-z @liamsms