Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt site component page code panel closes when switching between examples #2314

Closed
3 of 10 tasks
james-nash opened this issue Aug 29, 2023 · 0 comments · Fixed by #2322
Closed
3 of 10 tasks

Salt site component page code panel closes when switching between examples #2314

james-nash opened this issue Aug 29, 2023 · 0 comments · Fixed by #2322
Assignees
Labels
type: bug 🪲 Something isn't working

Comments

@james-nash
Copy link
Contributor

Package name(s)

Core (@salt-ds/core)

Package version(s)

n/a - this is a bug on the website

Description

"Show code" switch on component pages doesn't persist when switching between examples

(originally reported by @origami-z)

Steps to reproduce

  1. Go to a component page (e.g. https://www.saltdesignsystem.com/salt/components/button/index)
  2. Ensure the "All examples" switch is set to off, so that the list view of examples is used
  3. Flip the "Show code" switch to display the current example's code
  4. Select a different example

The example code panel will close.

Expected behavior

Code preview should remain open (but change its contents to the newly selected example).

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant