Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Types #498

Open
DavieReid opened this issue Sep 29, 2023 · 2 comments
Open

Package Types #498

DavieReid opened this issue Sep 29, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@DavieReid
Copy link
Contributor

Use https://arethetypeswrong.github.io/ to verify that we are shipping the correct package.json config to ensure types are configured correctly.

We only support node 18 and ESM so any result for CJS or older node versions is irrelevant.

@DavieReid DavieReid added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Sep 29, 2023
@DavieReid DavieReid added this to the Plugin Milestone milestone Sep 29, 2023
@MayankPrasher
Copy link

hey david , could u explain what should be the inputs to check this ? Maybe i could help you

@DavieReid
Copy link
Contributor Author

Hi there!

An example package name would be:

@jpmorganchase/mosaic-core

The linked site will run a check and show you if the package config is working for users. It will run checks for things we don't support like commonjs so it's fine if those show as failures.

All folders inside the packages directory have a package.json file, and in there you can find the package names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants