Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom export missing item images #195

Open
BenMcH opened this issue Sep 30, 2024 · 0 comments
Open

Atom export missing item images #195

BenMcH opened this issue Sep 30, 2024 · 0 comments

Comments

@BenMcH
Copy link

BenMcH commented Sep 30, 2024

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

I found that the atom export did not currently support images in the way that my current RSS feed has them exported. This adds them as I'd expect.

Here is the diff that solved my problem:

diff --git a/node_modules/feed/lib/atom1.js b/node_modules/feed/lib/atom1.js
index 18c1d2a..37a3024 100644
--- a/node_modules/feed/lib/atom1.js
+++ b/node_modules/feed/lib/atom1.js
@@ -8,7 +8,7 @@ exports.default = (function (ins) {
     var base = {
         _declaration: { _attributes: { version: "1.0", encoding: "utf-8" } },
         feed: {
-            _attributes: { xmlns: "http://www.w3.org/2005/Atom" },
+            _attributes: { xmlns: "http://www.w3.org/2005/Atom", "xmlns:media": "http://search.yahoo.com/mrss/" },
             id: options.id,
             title: options.title,
             updated: options.updated ? options.updated.toISOString() : new Date().toISOString(),
@@ -93,6 +93,10 @@ exports.default = (function (ins) {
         if (item.copyright) {
             entry.rights = item.copyright;
         }
+        if (item.image) {
+            entry['media:thumbnail'] = { _attributes: { url: item.image } };
+            entry['media:content'] = { _attributes: { medium: 'image', url: item.image } };
+        }
         base.feed.entry.push(entry);
     });
     return convert.js2xml(base, { compact: true, ignoreComment: true, spaces: 4 });

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant