Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in IE8, reported by Denis #269

Closed
thepag opened this issue Dec 9, 2014 · 5 comments
Closed

Bug in IE8, reported by Denis #269

thepag opened this issue Dec 9, 2014 · 5 comments
Labels

Comments

@thepag
Copy link
Contributor

thepag commented Dec 9, 2014

Noting this issue reported directly to me.

jquery.jplayer.js not work in IE8
on line 1028 not support "indexOf"

self.aurora.canPlay[format] = (self.aurora.formats.indexOf(format) > -1);

need replace like:

self.aurora.canPlay[format] = ($.inArray(format, self.aurora.formats) > -1);
@thepag thepag added the Bug label Dec 9, 2014
@thepag
Copy link
Contributor Author

thepag commented Dec 9, 2014

Confirmed this bug.

The problem is with the line 1028 as described:

self.aurora.canPlay[format] = (self.aurora.formats.indexOf(format) > -1);

The primary problem is that the self.aurora.formats property is an Array instead of a String.

I plan to use code along the lines of:

self.aurora.canPlay[format] = !!self.aurora.formats.[format];

Since this is a major bug, I will be fixing it this afternoon.

@thepag
Copy link
Contributor Author

thepag commented Dec 9, 2014

Actually, the Florentine air must be getting to me... I'm going with the original suggestion and using $.inArray

self.aurora.canPlay[format] = ($.inArray(format, self.aurora.formats) > -1);

@thepag thepag closed this as completed in f00ba69 Dec 9, 2014
@Afterster
Copy link
Contributor

Mh indeed, this bug was introduced by my Aurora.js PR, sorry about that and thanks for the report / fix.

@thepag
Copy link
Contributor Author

thepag commented Dec 9, 2014

I do not know how I let it slip through either. Would have sworn I'd tested it in an IE8 VM of XP, but apparently not 😒

@jeongjaehan
Copy link

good! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants