Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal Report Version #1349

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Minimal Report Version #1349

merged 7 commits into from
Nov 28, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Oct 24, 2023

This PR adds a minimal requiered report version to the report viewer.
This version is displayed on the landing page.
Reports generated with a lower version will not be accepted

This was linked to issues Oct 24, 2023
Report viewer unexpectedly requires a new minimal JPlag version. #963
Closed
Add minimal update notifications #1001
Closed
@Kr0nox Kr0nox requested a review from sebinside October 24, 2023 08:18
@sonarqubecloud
Copy link

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Kr0nox Kr0nox added this to the v5.0.0 milestone Oct 27, 2023
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Nov 22, 2023
sebinside
sebinside reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@sebinside sebinside left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again only minor comments, see above

@Kr0nox Kr0nox requested a review from sebinside November 27, 2023 16:10
@sonarqubecloud SonarQubeCloud
Copy link

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
7.8% 7.8% Duplication

@Kr0nox Kr0nox merged commit 45d3442 into develop Nov 28, 2023
13 checks passed
@Kr0nox Kr0nox deleted the report-viewer/min-version branch November 28, 2023 16:05
@tsaglam tsaglam mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfuchss dfuchss dfuchss left review comments

@sebinside sebinside sebinside approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

Add minimal update notifications Report viewer unexpectedly requires a new minimal JPlag version.
4 participants
@Kr0nox @sebinside @dfuchss @tsaglam