Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java Language Frontend: J_CONSTR_BEGIN, J_CONSTR_END and J_VOID never used #1865

Open
euberdeveloper opened this issue Jul 10, 2024 · 2 comments
Open

Java Language Frontend: J_CONSTR_BEGIN, J_CONSTR_END and J_VOID never used #1865

euberdeveloper opened this issue Jul 10, 2024 · 2 comments
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change

Comments

@euberdeveloper
Copy link

It can be seen from the code that these token types for Java are never used:

image
@euberdeveloper
Copy link
Author

The same can be said for other tokens

image

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Jul 11, 2024
@tsaglam
Copy link
Member

tsaglam commented Jul 11, 2024 •
edited
Loading

Yes, the unused tokens and the comments after each line are very much legacy. Some of them should not be used during tokenization as they decrease detection quality by enlarging the attack surface. For others, it is unclear if they have an impact at all (if used).

@tsaglam tsaglam mentioned this issue Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsaglam @euberdeveloper