Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #6

Open
virtuald opened this issue Nov 19, 2014 · 4 comments · May be fixed by #17
Open

Python 3 compatibility #6

virtuald opened this issue Nov 19, 2014 · 4 comments · May be fixed by #17

Comments

@virtuald
Copy link
Contributor

I intend to adapt pygazebo so it can be used successfully on python 3.x -- I don't expect many problems, except that protobuf 2.6 isn't quite py3 compatible yet (see protocolbuffers/protobuf#7), but it looks like that will change very very soon.

I'll try to link my PR's to this bug until all the issues are resolved.

@jpieper
Copy link
Owner

jpieper commented Nov 19, 2014

Thanks. I had originally intended for it to be python 2 or 3 compatible, but when I couldn't easily get protobuf working back when I started, I gave up, and some of the python3 requirements may have bitrotted in that time.

@virtuald
Copy link
Contributor Author

I've got a working protobuf working on my machine, but it was a pain. Hopefully that will be resolved soon. From what I've hit so far, there are byte/str problems -- but I'll work through those tonight and hopefully have it working. Then we just wait for protobuf.

@jpieper
Copy link
Owner

jpieper commented Dec 1, 2014

For the record, when you think you have it working, you should update the tox.ini to include at least one python3 variant and get all the tests to pass there as well.

@virtuald
Copy link
Contributor Author

virtuald commented Dec 1, 2014

Yup yup. I'll also update the travis.yml too. I don't want to update that until protobuf has a pypi package that is python3 compatible.

@virtuald virtuald linked a pull request Jan 2, 2015 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants