Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <img> with PDF display #13

Open
choilmto opened this issue May 16, 2019 · 1 comment
Open

Replace <img> with PDF display #13

choilmto opened this issue May 16, 2019 · 1 comment

Comments

@choilmto
Copy link
Collaborator

See pdf.worker.js.

@choilmto choilmto changed the title Replace <img? with PDF display Replace <img> with PDF display May 16, 2019
@jpetso
Copy link
Owner

jpetso commented May 16, 2019

Related: Electron Forge is working towards their 6.0 release - see e.g. electron/forge#621, https://v6.electronforge.io/cli - and is replacing the deprecated electron-compile package with webpack as default configuration. Best feature is that it's actually documented how to set up webpack now (as a JS noob, I've been struggling to understand how the pieces come together).

Once Electron Forge 6.0 is out, we should switch over, update all of our dependencies accordingly, use webpack and thus get proper support for pdf.worker.js via ES6 imports.

We can also consider upgrading to 6.0 and webpack earlier than the actual release, but I wonder whether that'll be more trouble than just waiting for a bit longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants