Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for FabricPlaceholderAPI #63

Open
forkiesassds opened this issue May 20, 2021 · 5 comments
Open

[Feature Request] Support for FabricPlaceholderAPI #63

forkiesassds opened this issue May 20, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@forkiesassds
Copy link

forkiesassds commented May 20, 2021

Is your feature request related to a problem? Please describe.
The only placeholders I can use right now are the player online and max player slot ones included with the mod.

Describe the solution you'd like
Support for FabricPlaceholderAPI would be awesome as there is a mod called Box of Placeholders that adds more placeholders to use with the mod

Describe alternatives you've considered
None.

Additional context
None, it's just a feature request to add support for a Fabric placeholder mod.

@forkiesassds forkiesassds added the enhancement New feature or request label May 20, 2021
@Patbox
Copy link

Patbox commented Jun 14, 2021

Author of Placeholder API here! Checked the source and I can say adding basic support (only global/server variables, without per player ones) should be easy! You just need to wrap text from toNative call with PlaceholderAPI.parseText(text, server). Getting per player placeholders should still be possible, but it will require more trickery (that might not be worth it).

@Patbox
Copy link

Patbox commented Dec 12, 2021

I will quick bump/ping, as I could pr it (through it's 1 line of code for full support). But would you be interested in it @jpenilla?

@sternschnaube
Copy link

Hello @Patbox and @jpenilla, I would love to "revive" this request from @forkiesassds.
It's now over one year old - any update on this?
Would be awesome to have Placeholder integration 💖

@Patbox
Copy link

Patbox commented Dec 24, 2022

Checked the code and there is nothing new there. I can't do much unless jpenilla implements it

@sternschnaube
Copy link

Thank you. I hope @jpenilla finds time to look into that / is willing to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants