Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure credentials should be configurable separately #133

Closed
pappasam opened this issue Mar 29, 2018 · 1 comment
Closed

Secure credentials should be configurable separately #133

pappasam opened this issue Mar 29, 2018 · 1 comment
Assignees
Milestone

Comments

@pappasam
Copy link

Like many others, I store my dotfiles on Github. "slack-term.json" cannot be backed up to version control because it MUST contain a valid "slack_token" (which I do not want the world to see).

In order to solve the problem, we would need to configure the parameter "slack_token", and any other potentially security-related parameters, with:

  1. Environment variables
  2. Command line arguments on startup
  3. A separate configuration file that gets merged with the one I store in version control

Options 1 and 2 seem most-promising; maybe both? It looks like config/config.go would need to be updated to handle checks for both the file itself and the existence of the variable in another location.

For reference: http://www.catb.org/esr/writings/taoup/html/ch10s06.html

Please let me know if you'd like my assistance, or if you'd prefer considering this design yourself. Thanks again for building this project and continuing to maintain it!

@jpbruinsslot
Copy link
Owner

Thank you for the kind words! I agree option 1 and 2 are the more straight forward options. I'll have a look at it.

@jpbruinsslot jpbruinsslot added this to the v0.3.3 milestone Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants