-
Notifications
You must be signed in to change notification settings - Fork 652
Adds blacklist token feature as separate subapp #91
Conversation
…g requests arent using black listed token
Tested this in a local project by logging into my app with a distant expiring JWT_EXPIRATION_DATE, issuing a POST to /api/v1/auth-token-blacklist/ with the token, and then attempting to access the api (navigated to another page with api call). A 401 Unauthorized is issued and I am logged out of my ember app as expected... Let me know if anyone has input.. seems like nice feature |
Should this package include an admin.py for the default black list token implementation? Should the JWTBlackListToken model include any other fields like the actual token value? |
@erichonkanen nice work! I'd add the |
@avimeir thanks! should the exp be a DateTimeField or CharField? I know the format it comes in as is seconds since epoch |
Made it DateTimeField and just converted |
…list token serializer, fixed import issue with tests
…s now it's either installed or not.
@jpadilla ran git rebase, fixed conflicts but Im noticing this effectively made a 2nd copy of every commit now at the front.. is this expected or did I do it wrong? Ive mostly just used rebase to squash commits in the past... |
@erichonkanen oh snap, could you perhaps squash all of this into one commit then? |
Cleaned commit history and submitted in new PR |
How can i implement this feature @erichonkanen ? |
Builds off work submitted by @avimeir and the discussion at #89