Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod names #36

Closed
rcgeorge23 opened this issue May 4, 2023 · 4 comments
Closed

Pod names #36

rcgeorge23 opened this issue May 4, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@rcgeorge23
Copy link
Contributor

Hi Vincent,

Is it possible to have any influence over the names that are assigned to pods when they are created in kubernetes?

Thanks

@joyrex2001
Copy link
Owner

How would you like to see that? I am thinking based on the container name with the container id as suffix?

@rcgeorge23
Copy link
Contributor Author

I was thinking there could be an optional label you could add to a container so users of kubedock could specify something that's meaningful for their use case (with a unique suffix appended to avoid name clashes). If provided, this would be used instead of the default randomly generated name.

For our use case, it would be good to see the name of the service (which is usually part of the image name), the image version and something that groups the pods together as being part of the same test run

@joyrex2001 joyrex2001 added the enhancement New feature or request label May 14, 2023
joyrex2001 added a commit that referenced this issue May 16, 2023
@joyrex2001
Copy link
Owner

I have added a label com.joyrex2001.kubedock.name-prefix which can be used to add a prefix to the deployed containers. If a name is specifically given to the container, this will be used in the deployment as well. To avoid naming conflicts I left the container id in the name.

@rcgeorge23
Copy link
Contributor Author

Amazing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants