This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
net: do not set V4MAPPED on FreeBSD #18204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on FreeBSD 10.1-RELEASE-p6. |
|
I didn't add a regression test for this specific problem since |
|
/cc @joyent/node-coreteam. |
misterdjules
force-pushed
the
fix-issue-8540
branch
from
4bf36f5
to
ce83321
Compare
|
LGTM if the CI is happy. It might be worth adding this to the docs. |
|
LGTM |
|
@misterdjules maybe just mention here that |
|
@cjihrig Good catch, will do and thank you! |
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes nodejs#8540 and nodejs#9204.
misterdjules
force-pushed
the
fix-issue-8540
branch
from
ce83321
to
1d47b40
Compare
|
@cjihrig Updated. |
|
LGTM |
misterdjules
pushed a commit
that referenced
this pull request
Apr 28, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes #8540 and #9204. Reviewed-By: Colin Ihrig <[email protected]> PR-URL: #18204
|
Thank you, landed in 0e392f3. |
cjihrig
pushed a commit
to nodejs/node
that referenced
this pull request
May 15, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: #1555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
rvagg
pushed a commit
to rvagg/io.js
that referenced
this pull request
May 27, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: nodejs#1555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 17, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: #1555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 22, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: #1555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 24, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: #1555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules
pushed a commit
to nodejs/node
that referenced
this pull request
Jul 30, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: #1555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 1, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: #1555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 3, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: #1555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 4, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: #1555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
misterdjules
pushed a commit
to nodejs/node
that referenced
this pull request
Aug 4, 2015
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1. Thus, do not set this flag in net.connect on FreeBSD. Fixes: nodejs/node-v0.x-archive#8540 Fixes: nodejs/node-v0.x-archive#9204 PR-URL: nodejs/node-v0.x-archive#18204 PR-URL: #1555 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
Thus, do not set this flag in net.connect on FreeBSD.
Fixes #8540.