[BUG] KDE Neon is reported as Debian Bookworm/Sid

[Jay2645]

Describe the bug
When a computer is running go-hass-agent with KDE Neon, the distribution is instead reported as Debian Bookworm/Sid. (Neon is based on Ubuntu LTS.)

To Reproduce
Steps to reproduce the behavior:

1. Install go-hass-agent on a machine/VM running KDE Neon
2. Open Home Assistant
3. Look at the reported distribution

Expected behavior
The distribution should report KDE Neon.

Screenshots

Logs
go-hass-app.log

Desktop (please complete the following information):

• OS: KDE neon 5.27 x86_64 (Kernel: 6.2.0-39-generic)
• Browser: I suspect this template was made for a web dev, but I use Microsoft Edge (Chromium version)
• Version: Version 120.0.2210.91 (Official build) (64-bit)

[joshuar]

This might be complicated to solve. I'm relying on the github.com/shirou/gopsutil/v3/host package to get the OS/distro information. From my grokking of the code it looks to preference getting the information from /etc/debian_version as opposed to other sources. I just spun up a KDE Neon live install and /etc/debian_version does report the Debian/bookworm info.

So I'm pretty sure this is the same problem as say, this person on PopOS is having with the above library: shirou/gopsutil#1469

I'd really like to avoid writing the code for this myself, because inevitably it might end up being a very big switch/else-if block that needs constant updating. Alternatively, I could just assume a canonical source like /etc/os-release and if a distro doesn't support that, it's gonna get "Unknown/Unknown" values. I will mention to the upstream library maintainer about whether adopting some hierarchy of places to get distro/version information would be good.

[joshuar]

I opened shirou/gopsutil#1576 upstream for discussion as well.

[joshuar]

Hey there, just circling back that since v9 the distribution should be reported correctly. Please let me know if it is not reporting the correct values for you!

[Jay2645]

Hmm - just updated to see, and it's still reporting Sid for some reason:

[Jay2645]

I'm still on KDE Neon:

[joshuar]

Ugh, so I wrote code to get the correct values, but I didn't actually change those sensors to use it 🤦

But that code wasn't enough, so I've refactored it and now it should be displaying the correct details in those sensors.

Can you try out the snapshot build from here:

https://github.com/joshuar/go-hass-agent/actions/runs/9218443179/artifacts/1533556590

This is an archive containing all the packages that would normally be on the release page (for amd64). It will effectively be the next release 🤞 Please extract and use the appropriate one.

Let me know if this works correctly!

[joshuar]

Hey there, I expect that the latest version (v9.4.0) should fix this issue. Can you please try with that version and report back?

[joshuar]

Hey there, I'm going to close this issue on the assumption it is now fixed. Please try with the latest release and re-open if this is still an issue.

[Jay2645]

Hey! Sorry, work's been a PITA recently. It's fixed in 9.5 for sure. Thank you!