Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add syntax highlight for html on template literals #3

Open
alejandrosanabriav opened this issue Dec 21, 2016 · 2 comments
Open

add syntax highlight for html on template literals #3

alejandrosanabriav opened this issue Dec 21, 2016 · 2 comments

Comments

@alejandrosanabriav
Copy link

It would be nice if template literals html get highlight!

@joshpeng
Copy link
Owner

joshpeng commented Dec 21, 2016

@developersoul I looked into it. This would be a pretty big feature set to try and create. The main issue is that the backtick for template literals don't necessarily mean it is for a template literal. Furthermore, it is incredibly difficult for tmLanguage to classify the proper grammar for the contents of the template literal.

I think the only feasible solution is to do similar to how language-babel package on Atom does it with a user-defined custom template prefix typed into the code before the template literal. This avoids the need of the babel grammar from trying to guess what embedded grammar is.

For example, in order to syntax highlight this

const template = `<div></div>`

You would need to first define a template prefix like /* @html */ and then shove that right before the template literal.

const template = /* @html */`<div></div>`

For now, I'll leave this as a feature request. Thanks.

@juangl
Copy link

juangl commented Mar 18, 2017

It'd be nice to support it in this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants