Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIrefox restore session tab name #539

Open
1 task done
axelKeizoStahl opened this issue Oct 4, 2024 · 5 comments
Open
1 task done

FIrefox restore session tab name #539

axelKeizoStahl opened this issue Oct 4, 2024 · 5 comments
Labels
i-bug Something might be broken in Tab Stash upstream dependency Something upstream (e.g. in Firefox or a dependency) needs to change to address this issue

Comments

@axelKeizoStahl
Copy link

OS Version

Arch Linux

Browser Version

Firefox 130.0.1

Tab Stash Version

3.1

Installed Extensions

  • ublock origin
  • vimium
  • BlockChan
  • Dark Reader
  • 4chan faster images

Problem Description

When firefox has its restore session prompt, and you click restore, the name of the current tab is changed to session restore for a moment. But then once that tab loads it changes back to the actual title of the tab.
However, tab stash still labels it as session restore.

Steps to Reproduce

  1. quit out of firefox
  2. get the session restore prompt and accept
  3. tab stash labels the current tab as "Session Restore"

Expected Behavior

Instead, it should change to the actual title of that site once the site loads.

Impact

No response

Additional Details

No response

Vote for This Issue

  • Readers: If you are also experiencing this problem, please vote for it by giving the ORIGINAL POST a thumbs-up using the 😃 button below. You are welcome to leave comments and discuss the issue if you have more details to add, but "Me too!" comments are not counted by the voting system.
@axelKeizoStahl axelKeizoStahl added the i-bug Something might be broken in Tab Stash label Oct 4, 2024
@josh-berry
Copy link
Owner

Afraid I'm not able to reproduce this. How are you getting the restore session prompt to appear?

@axelKeizoStahl
Copy link
Author

Revised steps to get restore session:

  • run firefox and open some tabs
  • run killall firefox to stop firefox
  • open firefox back up, and you should be greeted with a restore session prompt

@axelKeizoStahl
Copy link
Author

image
Here is an example, as you can see the focused tab is youtube, and yet it is still displaying Restore Session

@josh-berry
Copy link
Owner

Got it, thanks. Killing Firefox doesn't bring up the "Restore Session" prompt for me, it just restores the session and so I don't see this.

Without a way to reproduce this, I have no way to confirm it, but it's quite likely the issue is that Firefox is just not reporting the change in tab title when you click "Restore". If that's actually the case, there's unfortunately not much I can do about it.

Does reloading the Tab Stash UI fix the tab title? You can reload it by closing and reopening the sidebar, or by switching to a different sidebar and then switching back to Tab Stash again.

@axelKeizoStahl
Copy link
Author

Yeah, reloading the Tab Stash UI is what I've been doing so far, its too bad that there isn't really a good fix. Thanks for the help 👍

@josh-berry josh-berry added the upstream dependency Something upstream (e.g. in Firefox or a dependency) needs to change to address this issue label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i-bug Something might be broken in Tab Stash upstream dependency Something upstream (e.g. in Firefox or a dependency) needs to change to address this issue
Projects
None yet
Development

No branches or pull requests

2 participants