Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Stash window does not retheme automatically when toggling light/dark mode #448

Open
derlade opened this issue Feb 14, 2024 · 2 comments
Labels
upstream dependency Something upstream (e.g. in Firefox or a dependency) needs to change to address this issue

Comments

@derlade
Copy link

derlade commented Feb 14, 2024

System Details

  • OS Version: Linux 6.7.4-arch1-1
  • Browser Version: Firefox 122.0.1
  • Tab Stash Version: 3.0

Installed Browser Extensions:

  • None that should interfere with Tab Stash according to the known incompatibility list

Describe the Bug

When the system theme (light/dark) is switched globally, Firefox recognizes this and also switches its theme automatically (if configured appropriately). Unfortunately, this does not apply to Tab Stash (or other tab management addons such as Sidebery), such that the previously enabled theme stays enabled. Closing and reopening the sidebar via Ctrl-Alt-S does not retheme the window, but weirdly enough opening Firefox sidebars such as bookmarks or history (or having them opened during global theme switch) forces Tab Stash to redraw and switch its theme.

Steps to Reproduce

  1. Have Firefox and Tab Stash openend
  2. Switch system theme globally (I do this with Night Theme Switcher in GNOME)
  3. Observe that Tab Stash has not redrawn its window
  4. Open bookmarks (Ctrl-B) or history (Ctrl-H) and switch back to Tab Stash
  5. Observe that Tab Stash has now applied the current global theme

Expected Behavior

Tab Stash redraws its window immediately after global theme switch

Impact

Small usability issue


Readers: If you are also experiencing this bug, please vote for it by giving the ORIGINAL POST a thumbs-up using the 😃 button. You are welcome to leave comments and discuss the issue if you have more details to add, but "Me too!" comments are not counted by the voting system.
@derlade
Copy link
Author

derlade commented Feb 16, 2024

Some additional quirks: If Firefox is newly opened with either Tab Stash opened in the sidebar or without any sidebar, switching themes also redraws the sidebar window. As soon as the sidebar is changed to showing bookmarks or history, immediate theme switching is broken for the Tab Stash window.

@josh-berry
Copy link
Owner

Interesting! Unfortunately, this seems like a Firefox bug, and not something I can do much about in Tab Stash. Tab Stash only tells Firefox which colors to use in which mode, and Firefox decides when to apply them (there is no logic in Tab Stash for handling switching per se). So it seems likely Firefox is just not telling its sidebar when the switch happens, for some reason.

Thanks for letting me know though, I'll leave this open in case others run into it too and can shed more light on what's happening.

@josh-berry josh-berry added upstream dependency Something upstream (e.g. in Firefox or a dependency) needs to change to address this issue i-bug Something might be broken in Tab Stash and removed i-bug Something might be broken in Tab Stash labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream dependency Something upstream (e.g. in Firefox or a dependency) needs to change to address this issue
Projects
None yet
Development

No branches or pull requests

2 participants