From 4726b1c6a63ce01f5956c8aef60e72275152ae32 Mon Sep 17 00:00:00 2001
From: Joseph Frazier <1212jtraceur@gmail.com>
Date: Tue, 15 Oct 2024 17:30:54 -0400
Subject: [PATCH] Make "TLC Service Request Number" clearer for non-TLC
 vehicles (#549)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

See https://www.reddit.com/r/NYCbike/comments/1ftea2k/how_does_reported_web_app_work/:

> Does anything happen with non-TLC submissions? I’ve had success
> reporting cars before just using 311 although reported makes it really
> easy. but it seems my other submissions aren’t getting submitted to 311?
> see photo.

> Apologies for the delay, but I figured out what was going on, with the
> help of the founder of Reported.
>
> Due to a quirk in how Reported app submissions are processed on the
> backend (which is a different, closed-source code base), non-TLC
> submissions do indeed get sent to 311 as a Service Request that 311
> routes to the NYPD, but the SR number doesn't get stored in the same
> database table that a TLC submission's 311 SR number would (because
> Reported submissions for TLC plates become two 311 SRs, one for TLC and
> one for NYPD), so the web app frontend currently acts as if the
> submission was never processed by the Reported backend, even though it
> was.
>
> In the short term, I'll try to update the text on the webapp to indicate
> this ambiguity, and in the long term, I may be able to update the webapp
> to show all relevant 311 SR numbers for a given Reported submission,
> both NYPD and TLC (if applicable).
>
> As for how to know whether the NYPD SR has been created: If you've made
> a subsequent Reported submission for a TLC plate and the SR number does
> appear, then you can be confident that the non-TLC submission's NYPD SR
> has been created, since the Reported backend processes submissions
> chronologically.
>
> Let me know if that makes sense, I'm happy to explain further!

See also the Slack thread for further investigation: https://reportedcab.slack.com/archives/C802R14UX/p1727754085142069
---
 src/components/SubmissionDetails.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/components/SubmissionDetails.js b/src/components/SubmissionDetails.js
index 95456365..a50c5332 100644
--- a/src/components/SubmissionDetails.js
+++ b/src/components/SubmissionDetails.js
@@ -109,6 +109,11 @@ class SubmissionDetails extends React.Component {
         </button>
       );
 
+    const displayReqnumber =
+      reqnumber === 'N/A until submitted to 311'
+        ? 'N/A: Either not yet submitted to 311, or is a non-TLC vehicle and therefore does not have a TLC SR'
+        : reqnumber;
+
     return (
       <details
         open={this.state.isDetailsOpen}
@@ -123,7 +128,7 @@ class SubmissionDetails extends React.Component {
           {/* eslint-disable-next-line camelcase */}
           {(loc1_address || '').split(',')[0]} on {humanTimeString}
           <br />
-          TLC Service Request Number: {reqnumber}
+          TLC Service Request Number: {displayReqnumber}
         </summary>
 
         {this.state.isDetailsOpen && (