Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TaxCurrencyCode (BT-6) #22

Closed
andras-minicrm opened this issue May 26, 2022 · 3 comments
Closed

Add support for TaxCurrencyCode (BT-6) #22

andras-minicrm opened this issue May 26, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@andras-minicrm
Copy link

Hi @josemmo

First: thanks for this awesome library!

I'm currently developing integration with anaf (romanian tax authority). They use a special ruleset: RO_CIUS
They have a special (fatal) rule:
BR-RO-030: If the "Invoice Currency Code" (BT-5) is other than "RON", then the item "VAT Accounting Currency Code" (BT-6) must be "RON".

It seems the library doesn't have a support for BT-6. We've created two xml-s with smartbill I've attached them here. However BT-6 requires an extra:

<cac:TaxTotal>
    <cbc:TaxAmount currencyID="RON">93.89</cbc:TaxAmount><!--BT-111-->
</cac:TaxTotal>

so BT-6 maybe needs an exchange rate option to correctly calculate the amount (eg: EUR to RON: 4.1234, RON to RON 1.000)?

Samples:
RON2RON.txt
EUR2RON.txt

(these are xmls but github doesn't allow xml uploads)

@josemmo
Copy link
Owner

josemmo commented May 28, 2022

Hello @andras-minicrm,

Thanks for the feedback! I've implemented the feature, will be merged in the next release.

@josemmo josemmo added the enhancement New feature or request label May 28, 2022
@andras-minicrm
Copy link
Author

Amazing, thx!! When the next release scheduled?

@josemmo
Copy link
Owner

josemmo commented May 30, 2022

We don't have a scheduled release cycle, the next release will be (probably) in June.

@josemmo josemmo closed this as completed in 8ce204e Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants