Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the Forms on a precompiled hook #192

Closed
wants to merge 2 commits into from

Conversation

NelsonVides
Copy link
Contributor

This is my attempt at solving #187 :)

@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #192 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   84.62%   84.68%   +0.06%     
==========================================
  Files          12       12              
  Lines        2211     2207       -4     
==========================================
- Hits         1871     1869       -2     
+ Misses        340      338       -2
Impacted Files Coverage Δ
src/gradualizer_db.erl 71.7% <100%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb41bac...a49162d. Read the comment docs.

@josefs
Copy link
Owner

josefs commented Sep 25, 2019

Thanks for your contribution, @NelsonVides! As discussed in #187 we're going with the PR by @gomoripeti so I'm closing this PR.
Don't be discouraged though, we'd be happy to see more contributions from you.

@josefs josefs closed this Sep 25, 2019
@NelsonVides NelsonVides deleted the otp_22_prelude_issue branch September 25, 2019 08:10
@zuiderkwast
Copy link
Collaborator

Pretty nice approach!

@NelsonVides NelsonVides restored the otp_22_prelude_issue branch October 3, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants